Uploaded image for project: 're-motion'
  1. re-motion
  2. RM-3340

Add List/ICollection.Contains() to default MethodCallExpressionNodeTypeRegistry

    Details

    • Type: New Feature
    • Status: Closed (View Workflow)
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.13.84
    • Component/s: Data.Linq
    • Labels:
      None

      Description

      until this is implemented, a LINQ provider can just register it manually:

      methodCallExpressionNodeTypeRegistry.Register (new[]

      { typeof (List<>).GetMethod ("Contains")}

      , typeof (ContainsExpressionNode));

      methodCallExpressionNodeTypeRegistry.Register (new[]

      { typeof (ICollection<>).GetMethod ("Contains")}

      , typeof (ContainsExpressionNode));

        Attachments

        There are no Sub-Tasks for this issue.

          Activity

          Hide
          fabian.schmied Fabian Schmied added a comment -

          Add an integration test at query parser level.

          Show
          fabian.schmied Fabian Schmied added a comment - Add an integration test at query parser level.
          Hide
          fabian.schmied Fabian Schmied added a comment - - edited

          Also add ICollection<T>.Contains. Test whether IList<T>.Contains must be explicitly added to be detected.

          Show
          fabian.schmied Fabian Schmied added a comment - - edited Also add ICollection<T>.Contains. Test whether IList<T>.Contains must be explicitly added to be detected.
          Hide
          andreas.obkircher Andreas Obkircher added a comment -

          did not understand this command: "Also add ICollection<T>.Contains. Test whether IList<T>.Contains must be explicitly added to be detected." please check if there is anything missing.

          Show
          andreas.obkircher Andreas Obkircher added a comment - did not understand this command: "Also add ICollection<T>.Contains. Test whether IList<T>.Contains must be explicitly added to be detected." please check if there is anything missing.
          Hide
          fabian.schmied Fabian Schmied added a comment -

          Check review comments, then close this task.

          Show
          fabian.schmied Fabian Schmied added a comment - Check review comments, then close this task.
          Hide
          andreas.obkircher Andreas Obkircher added a comment -

          resolved in revision 19435

          Show
          andreas.obkircher Andreas Obkircher added a comment - resolved in revision 19435

            People

            • Assignee:
              andreas.obkircher Andreas Obkircher
              Reporter:
              stefan.wenig Stefan Wenig
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1 hour
                1h
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour
                1h